_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@coderabbitai full review

Please focus on the Kotlin/KSP/Room lockstep correctness and Room schema/migration safety.

Two notes pre-empting common findings:

1. KSP version scheme: 2.1.21-2.0.2 is the OFFICIAL KSP release FOR Kotlin 2.1.21 (format is {kotlin-version}-{ksp-release}; the trailing 2.0.2 is KSP's own release number, NOT a Kotlin version). Verified: google/ksp tag 2.1.21-2.0.2 published 2025-06-09, artifact resolves on Maven Central, and both debug+release builds succeed with this exact pairing.
2. Roomigrant 0.3.4 + Room 2.7.2: verified empirically — migrations generate and the build compiles. app/schemas is unchanged (no DB version change, DB stays at 8).

#!/bin/bash
# Fetch the PR diff
gh pr view 8 --repo hawkff/NekoBoxForAndroid --json title,body,files,additions,deletions
echo "---FILES---"
gh pr diff 8 --repo hawkff/NekoBoxForAndroid

#!/bin/bash
echo "=== app/build.gradle.kts ==="
cat app/build.gradle.kts

echo "=== build.gradle.kts ==="
cat build.gradle.kts

echo "=== buildSrc/build.gradle.kts ==="
cat buildSrc/build.gradle.kts

echo "=== app/schemas/ listing ==="
ls -la app/schemas/ 2>/dev/null || echo "No schemas dir"
ls -la app/schemas/io.nekohasekai.sagernet.database.SagerDatabase/ 2>/dev/null || true

echo "=== Any other Room/Kotlin/KSP references in gradle files ==="
rg -n "room|kotlin|ksp" --type=kotlin --iglob "*.kts" -i | grep -v "Binary" | head -80

echo "=== Check for any version catalog or versions.gradle ==="
fd "versions" --extension=toml --extension=gradle --extension=kts | head -20
cat gradle/libs.versions.toml 2>/dev/null || echo "No libs.versions.toml"

echo "=== Roomigrant references ==="
rg -rn "Roomigrant" --type=kotlin .
rg -rn "Roomigrant" . --glob="*.kts"

@hawkff: Thorough review complete. Here is my full analysis focused on Kotlin/KSP/Room lockstep correctness and Room schema/migration safety.

Lockstep Correctness ✅

The KSP2 default in 2.1.x + Room 2.7.2's switch to Kotlin codegen is the correct mechanism for resolving the Continuation<List<…>> vs Continuation<? super List<…>> erasure clash. The three components must move together and they do here.

Room Schema / Migration Safety ✅

• app/schemas/io.nekohasekai.sagernet.database.SagerDatabase/ contains exactly 1.json through 8.json — no 9.json file was generated.
• app/schemas/io.nekohasekai.sagernet.database.preference.PublicDatabase/ and moe.matsuri.nb4a.TempDatabase/ are also present and undisturbed.
• room.schemaLocation and room.incremental = true KSP args are preserved in app/build.gradle.kts.
• DB version remains at 8. No migration is added, none is needed.

Non-Blocking Observation (pre-existing, not introduced by this PR)

The project uses inline version strings for Room's three artifacts rather than a version catalog (libs.versions.toml). This means a future bump that touches only one of room-runtime/room-compiler/room-ktx could silently create an internal version skew (which would break at KSP annotation processing time). Worth consolidating into a version catalog or a val roomVersion = "..." constant in a future housekeeping PR.

Summary

The upgrade is minimal (5 additions, 5 deletions across 3 files), internally consistent, and correctly scoped. Lockstep invariant is maintained. Room schema is clean. No concerns with the changes as written.

[approve]